Date: Tue, 2 Feb 2016 10:17:51 +0000 (UTC) From: Svatopluk Kraus <skra@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r295141 - head/sys/arm/arm Message-ID: <201602021017.u12AHp9f060207@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: skra Date: Tue Feb 2 10:17:51 2016 New Revision: 295141 URL: https://svnweb.freebsd.org/changeset/base/295141 Log: Fix setting of protection bits for page table entries in pmap_map(). This function is only called from vm_page_startup() and vm_reserv_startup(). I.e. during vm subsystem initialization. As VM_PROT_WRITE is always used in these calls, the typo did not have any effect. Likely, it's the reason why it wasn't discovered so long. Modified: head/sys/arm/arm/pmap-v6.c Modified: head/sys/arm/arm/pmap-v6.c ============================================================================== --- head/sys/arm/arm/pmap-v6.c Tue Feb 2 10:11:56 2016 (r295140) +++ head/sys/arm/arm/pmap-v6.c Tue Feb 2 10:17:51 2016 (r295141) @@ -1325,7 +1325,7 @@ pmap_map(vm_offset_t *virt, vm_paddr_t s PDEBUG(1, printf("%s: virt = %#x, start = %#x, end = %#x (size = %#x)," " prot = %d\n", __func__, *virt, start, end, end - start, prot)); - l2prot = (prot & VM_PROT_WRITE) ? PTE2_AP_KRW : PTE1_AP_KR; + l2prot = (prot & VM_PROT_WRITE) ? PTE2_AP_KRW : PTE2_AP_KR; l2prot |= (prot & VM_PROT_EXECUTE) ? PTE2_X : PTE2_NX; l1prot = ATTR_TO_L1(l2prot);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201602021017.u12AHp9f060207>