Date: Mon, 12 Apr 2004 10:54:53 +0200 From: "Carlos Velasco" <freebsd@newipnet.com> To: "M. Warner Losh" <imp@bsdimp.com> Cc: freebsd-mobile@freebsd.org Subject: Re[3]: pccbb pccard rman - Something is very wrong somewhere Message-ID: <200404121054530262.26E7ABED@192.168.128.16> In-Reply-To: <200404090234530949.15ACB39A@192.168.128.16> References: <20040406.162834.02299817.imp@bsdimp.com> <20040406.231324.131273745.imp@bsdimp.com> <200404071245040782.0D909C4C@192.168.128.16> <20040407.092146.40772577.imp@bsdimp.com> <200404090234530949.15ACB39A@192.168.128.16>
next in thread | previous in thread | raw e-mail | index | archive | help
On 09/04/2004 at 2:34 Carlos Velasco wrote:
>However it does not work, it reads CIS but card doesn't work. I think it's
>because further resources (pccard0: ccr_res == 88002000-880023ff,
>base=ff80) need 64k alignment too for card to work.
Warner,
My laptop has <TI1225 PCI-CardBus Bridge>
I have been googling and have seen other problems related to this cardbus
in freebsd.
I think possible this "alignment" problem is related to this specific
cardbus chipset. I will review the pccbb code but I'm not an expert into
this.
On the other hand, could someone commit this for rman? It's a clear
mistake:
diff -ur sys/kern/subr_rman.c sysnew/kern/subr_rman.c
--- sys/kern/subr_rman.c Wed Jun 11 00:56:57 2003
+++ sysnew/kern/subr_rman.c Tue Apr 6 11:41:23 2004
@@ -234,7 +234,7 @@
rstart += bound - (rstart & ~bmask);
} while ((rstart & amask) != 0 && rstart < end &&
rstart < s->r_end);
- rend = ulmin(s->r_end, ulmax(rstart + count, end));
+ rend = ulmin(s->r_end, ulmax(rstart + count - 1, end));
if (rstart > rend) {
DPRINTF(("adjusted start exceeds end\n"));
continue;
Regards,
Carlos Velasco
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200404121054530262.26E7ABED>