Date: Tue, 02 Apr 2013 19:49:35 +0200 From: Alberto Villa <avilla@freebsd.org> To: Baptiste Daroussin <bapt@freebsd.org> Cc: Koop Mast <kwm@rainbow-runner.nl>, freebsd-ports@freebsd.org, kde-freebsd@kde.org Subject: Re: [kde-freebsd] py27-pykde4-4.10.1 Message-ID: <2804828.qOu8dtiYNA@indiana.smith> In-Reply-To: <20130402172440.GM56166@ithaqua.etoilebsd.net> References: <1505116.DpgL6T9iEl@luna.wi.rr.com> <12878738.sI6p4J2xBi@indiana.smith> <20130402172440.GM56166@ithaqua.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart80291812.fK7XhfGevH
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
On Tuesday 02 April 2013 19:24:40 Baptiste Daroussin wrote:
> bsd.options.mk can't anyway be loaded after bsd.port.pre.mk given that one
> may want to provide a PYTHON option and will make it set
USE_PYTHON=yes for
> example.
Sure, you're right.
> I don't know the right fix to be honnest. But UNIQUENAME not being UNIQUE
is
> a real problem imho and OPTIONSFILE changing depending on being after
> pre.mk or before pre.mk is another problem.
As far as I know LATEST_LINK should be unique (there was also a service
checking for duplicates)... What about UNIQUENAME=${LATEST_LINK}?
Anyway the problem is not with UNIQUENAME, it's with the usage of
PKGNAMESUFFIX. PKGNAMESUFFIX should be used by ports sharing the same
OPTIONS but with light differencies (e.g., variations of a single port); it
would be perfect. Unfortunately, time passed and it started being used the
wrong (so wrong) way. Either PKGNAMESUFFIX usage is fixed (among >20k
ports!), or UNIQUENAME is set to LATEST_LINK (or similar).
About the loading order, yes, it needs serious thought. At the same time, many
*.mk files need to be fixed as they don't distinguish between pre- and post-
makefile sections. Some day a vademecum has to be written about those two
sections, and I volunteer to help with that as I studied the matter quite well
in the past.
--
Alberto Villa, FreeBSD committer <avilla@FreeBSD.org>
http://people.FreeBSD.org/~avilla
There are two problems with a major hangover. You feel
like you are going to die and you're afraid that you won't.
--nextPart80291812.fK7XhfGevH
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
iJwEAAECAAYFAlFbGjIACgkQ3xiC6kQ1CosovwQAlONed0hRmtS0oJRTxH+9+flt
QWNyUsYaLh4H6VXvH2JL36qX+9L2f86Eg5WI6yCnFfm8lhl0sux+ODuwQnaNFqzr
BK24VkGyzQ8kHHXQy6JiWl/hh6NUFi2gnKL9WdDhQDcE1mJn9R66hlFt3wGmp7uD
ZVgzSvn2s+2+Y1RnVNc=
=LVWY
-----END PGP SIGNATURE-----
--nextPart80291812.fK7XhfGevH--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2804828.qOu8dtiYNA>