Date: Mon, 05 Nov 2001 17:13:00 -0800 From: Peter Wemm <peter@wemm.org> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: Robert Watson <rwatson@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/dpt dpt_control.c Message-ID: <20011106011301.3BF4B3807@overcee.netplex.com.au> In-Reply-To: <81991.1004999713@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
Poul-Henning Kamp wrote:
> In message <20011105221718.39AB73807@overcee.netplex.com.au>, Peter Wemm writ
es
> :
> >Robert Watson wrote:
> >> rwatson 2001/11/05 13:02:27 PST
> >>
> >> Modified files:
> >> sys/dev/dpt dpt_control.c
> >> Log:
> >> o dpt_control.c is not compiled into the system (commented out in
> >> conf/files) and as a result appears to have been missed in the bulk
> >> KSE update of drivers. This change replaces references to proc
> >> with thread. It has not been compile-tested.
> >
> >Actually, it got missed in the CAM update from 2.2.x -> 3.0 :-] It should
> >probably be sent to the attic so that it doesn't cause more confusion or
> >people to spend time on it unless they're going to port it to the CAM driver
> >as well.
>
> I think you're right.
>
>
> This is the output of kernelcruft.sh right now. Unless people come up
> with good reasons for the opposite, I suggest the marked files be
> banished to the attics:
>
> alpha/linux/linux_genassym.c
> >>> crypto/md5.c
> >>> dev/dpt/dpt_control.c
> >>> dev/dpt/dpt_isa.c
No, not this one... dpt_isa.c has just been left out of the build. I
believe it works.
> dev/fb/boot_font.c
> dev/fb/gfb.c
> dev/fb/s3_pci.c
> dev/fb/tga.c
> dev/gfb/gfb_pci.c
> dev/sound/pci/aureal.c
> dev/syscons/scgfbrndr.c
> dev/tga/tga_pci.c
> i386/linux/linux_genassym.c
> i386/svr4/svr4_genassym.c
> >>> i4b/driver/i4b_bsdi_ibc.c
> netinet/in_cksum.c
> netns/ns_cksum.c
> >>> pci/scsiiom.c
What on earth is this doing here? :-) It looks like its a leftover of
a replaced driver that did a "#include <pci/scsiiom.c>" in it. Everything
in it is static...
> powerpc/powerpc/busdma_machdep.c
>
>
> --
> Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
> phk@FreeBSD.ORG | TCP/IP since RFC 956
> FreeBSD committer | BSD since 4.3-tahoe
> Never attribute to malice what can adequately be explained by incompetence.
>
>
Cheers,
-Peter
--
Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au
"All of this is for nothing if we don't go to the stars" - JMS/B5
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011106011301.3BF4B3807>