Date: Sun, 5 Dec 2004 19:11:09 +0000 (UTC) From: Robert Watson <rwatson@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/netinet ip_output.c Message-ID: <200412051911.iB5JB9uL007878@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
rwatson 2004-12-05 19:11:09 UTC
FreeBSD src repository
Modified files:
sys/netinet ip_output.c
Log:
Start working through inpcb locking for ip_ctloutput() by cleaning up
modifications to the inpcb IP options mbuf:
- Lock the inpcb before passing it into ip_pcbopts() in order to prevent
simulatenous reads and read-modify-writes that could result in races.
- Pass the inpcb reference into ip_pcbopts() instead of the option chain
pointer in the inpcb.
- Assert the inpcb lock in ip_pcbots.
- Convert one or two uses of a pointer as a boolean or an integer
comparison to a comparison with NULL for readability.
Revision Changes Path
1.233 +13 -10 src/sys/netinet/ip_output.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200412051911.iB5JB9uL007878>