Date: Sat, 18 Sep 1999 17:25:10 -0500 (CDT) From: "Dean M. Phillips" <dphill@inav.net> To: FreeBSD-gnats-submit@freebsd.org Subject: misc/13819: Userland PPP filter parsing bug. Message-ID: <199909182225.RAA00722@deanstoy.dphill.inav.net>
next in thread | raw e-mail | index | archive | help
>Number: 13819
>Category: misc
>Synopsis: Userland ppp rejects "lt" operator in filter
>Confidential: no
>Severity: serious
>Priority: high
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Sep 19 07:10:01 PDT 1999
>Closed-Date:
>Last-Modified:
>Originator: Dean M. Phillips
>Release: FreeBSD 3.3-RC i386
>Organization:
None Whatsoever!
>Environment:
FreeBSD deanstoy 3.3-RC FreeBSD 3.3-RC #0: Sat Sep 11 09:51:31 CDT 1999 root@deanstoy:/usr/src/sys/compile/DEANSTOY i386
* $FreeBSD: src/usr.sbin/ppp/filter.c,v 1.26.2.5 1999/08/29 15:45:59 peter Exp $
>Description:
The command:
set filter in 9 deny tcp dst lt 1024
gives the error:
Warning: ParseUdpOrTcp: bad operation
>How-To-Repeat:
Start ppp and say:
set filter in 9 deny tcp dst lt 1024
>Fix:
Consider the following bit of filter.h - the numbers run consequtively:
/* Operations - f_srcop, f_dstop */
#define OP_NONE 0
#define OP_EQ 1
#define OP_GT 2
#define OP_LT 3
The following patch seems to fix it:
-------------------------------------------------------------------------
--- filter.c.~1~ Tue Sep 7 21:32:42 1999
+++ filter.c Fri Sep 17 22:20:14 1999
@@ -622,7 +622,7 @@
return proto;
}
-static const char *opname[] = {"none", "eq", "gt", "unknown", "lt"};
+static const char *opname[] = {"none", "eq", "gt", "lt", "unknown"};
const char *
filter_Op2Nam(int op)
-------------------------------------------------------------------------
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199909182225.RAA00722>