Date: Fri, 03 Apr 1998 22:21:11 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: "Alok K. Dhir" <adhir@worldbank.org>, ache@nagual.pp.ru, Alok_K._Dhir/Person/World_Bank@notes.worldbank.org, current@FreeBSD.ORG, adkin003@tc.umn.edu Subject: Re: Working patch *with* splhigh() (Was Re: More info RE: X slowdown in -current) Message-ID: <3490.891634871@critter.freebsd.dk> In-Reply-To: Your message of "Fri, 03 Apr 1998 22:15:37 %2B0200." <3445.891634537@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <3445.891634537@critter.freebsd.dk>, Poul-Henning Kamp writes:
And here is another one to try: Move the splhigh two lines up:
ncoll = nselcoll;
p->p_flag |= P_SELECT;
error = selscan(p, ibits, obits, uap->nd);
>>>> s = splhigh();
>>>> if (error || p->p_retval[0]) {
>>>> splx(s);
>>>> goto done;
>>>> }
if (term && term <= ticks) {
splx(s);
goto done;
}
timo = term ? term - ticks : 0;
if ((p->p_flag & P_SELECT) == 0 || nselcoll != ncoll) {
splx(s);
--
Poul-Henning Kamp FreeBSD coreteam member
phk@FreeBSD.ORG "Real hackers run -current on their laptop."
"Drink MONO-tonic, it goes down but it will NEVER come back up!"
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3490.891634871>