Date: Wed, 7 Nov 2012 01:02:01 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Ben Kaduk <minimarmot@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r241896 - in head: . cddl/contrib/opensolaris/lib/libzpool/common/sys share/man/man9 sys/cam/ctl sys/cddl/compat/opensolaris/kern sys/cddl/compat/opensolaris/sys sys/cddl/contrib/openso... Message-ID: <20121106230201.GN73505@kib.kiev.ua> In-Reply-To: <CAK2BMK5c==SJ%2BySe7S70ZJyph_2X%2BdU%2B9zBftdatWqTVsH5rsA@mail.gmail.com> References: <CAK2BMK5c==SJ%2BySe7S70ZJyph_2X%2BdU%2B9zBftdatWqTVsH5rsA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--eVN8q1r3v0Uw6/qa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 06, 2012 at 05:50:43PM -0500, Ben Kaduk wrote: > On Mon, Oct 22, 2012 at 1:50 PM, Konstantin Belousov <kib@freebsd.org> wr= ote: > > Author: kib > > Date: Mon Oct 22 17:50:54 2012 > > New Revision: 241896 > > URL: http://svn.freebsd.org/changeset/base/241896 > > > > Log: > > Remove the support for using non-mpsafe filesystem modules. > > > > In particular, do not lock Giant conditionally when calling into the > > filesystem module, remove the VFS_LOCK_GIANT() and related > > macros. Stop handling buffers belonging to non-mpsafe filesystems. > > > > The VFS_VERSION is bumped to indicate the interface change which does > > not result in the interface signatures changes. > > > > Conducted and reviewed by: attilio > > Tested by: pho > > >=20 > Sorry for late reply. >=20 > % --- head/sys/sys/namei.h 2011/12/29 12:28:05 228952 > % +++ head/sys/sys/namei.h 2012/10/22 17:50:54 241896 > % @@ -144,15 +144,11 @@ > % #define ISOPEN 0x00200000 /* caller is opening; return a real vnode. = */ > % #define NOCROSSMOUNT 0x00400000 /* do not cross mount points */ > % #define NOMACCHECK 0x00800000 /* do not perform MAC checks */ > % -#define MPSAFE 0x01000000 /* namei() must acquire Giant if needed. */ >=20 > It seems that removing the definition of MPSAFE causes out-of-tree > filesystem modules to not build. > Perhaps a definition can remain for some period to allow a smoother trans= ition? No, it shall not be left or restored, since its functionality is removed. > Conditional on __FreeBSD_Version is the proper fix, of course, but > takes longer to get everywhere. --eVN8q1r3v0Uw6/qa Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlCZlukACgkQC3+MBN1Mb4gj8wCgheQ4WQkMvoU3aoFU/4kGZqjj ap0AoIpozcNUlUgeuHvhHVlY8VY8TjEP =wQm4 -----END PGP SIGNATURE----- --eVN8q1r3v0Uw6/qa--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121106230201.GN73505>