Date: Tue, 6 Mar 2012 10:57:23 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Oleksandr Tymoshenko <gonzo@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r232580 - head/lib/csu/mips Message-ID: <20120306085723.GY75778@deviant.kiev.zoral.com.ua> In-Reply-To: <201203060329.q263TlLn017594@svn.freebsd.org> References: <201203060329.q263TlLn017594@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--+sXEj1HC0AeGgRD2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 06, 2012 at 03:29:47AM +0000, Oleksandr Tymoshenko wrote: > Author: gonzo > Date: Tue Mar 6 03:29:46 2012 > New Revision: 232580 > URL: http://svn.freebsd.org/changeset/base/232580 >=20 > Log: > - Remove NOSHARED parts since it seems to be no-op > - Call _init_tls for statically linked binaries >=20 > Modified: > head/lib/csu/mips/crt1.c >=20 > Modified: head/lib/csu/mips/crt1.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/lib/csu/mips/crt1.c Tue Mar 6 03:27:58 2012 (r232579) > +++ head/lib/csu/mips/crt1.c Tue Mar 6 03:29:46 2012 (r232580) > @@ -47,10 +47,8 @@ __FBSDID("$FreeBSD$"); > struct Struct_Obj_Entry; > struct ps_strings; > =20 > -#ifndef NOSHARED > extern int _DYNAMIC; > #pragma weak _DYNAMIC > -#endif > =20 > extern void _init(void); > extern void _fini(void); > @@ -91,10 +89,11 @@ __start(char **ap, > __progname =3D s + 1; > } > =20 > -#ifndef NOSHARED > if (&_DYNAMIC !=3D NULL) > atexit(cleanup); > -#endif > + else > + _init_tls(); > + > #ifdef GCRT > atexit(_mcleanup); > #endif Oh great. I tried to understand this bits for some time, due to init_array work, and was unable to make any sense of it. I will update the patchset to include MIPS now. --+sXEj1HC0AeGgRD2 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk9V0XIACgkQC3+MBN1Mb4gwkwCeLasAfaEpAQrVLAUhRKpBgqeL d7sAoKQNHipqeV+Ffb5YnPwOFfXlqs1Y =s7h0 -----END PGP SIGNATURE----- --+sXEj1HC0AeGgRD2--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120306085723.GY75778>