Date: Tue, 11 Jul 2023 07:27:50 -0700 From: Adrian Chadd <adrian.chadd@gmail.com> To: =?UTF-8?B?5ZCz5oGp57ev?= <rickywu0421@gmail.com> Cc: freebsd-wireless@freebsd.org Subject: Re: 802.11n TX ADDBA request supported? Message-ID: <CAJ-VmomeatKb0kWnfRjvr6FH-BD5BLG090dVzkDjdfBbOtQuPQ@mail.gmail.com> In-Reply-To: <CAM71UgdSSunt8w3CSOnqmZRu94KOHDvHgFsaSpZOSuY1_rkZeA@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] hi! So, ampdu_request doesn't send addba itself. It calls ic_send_action because some NICs want a firmware message to start AMPDU, not sending frames. Look at what ath(4) is doing. It registers for ic_send_action and that sends the actual frames. mwl(4) (an old 11n marvell chipset, the first with freebsd 11n support) instead uses a firmware message. -adrin On Tue, 4 Jul 2023 at 01:03, 吳恩緯 <rickywu0421@gmail.com> wrote: > Hi, > > I'm working on 14.0-CURRENT, and I found that it seems net80211(4) lack of > supporting 802.11n/e TX ADDBA request: > When we call `ieee80211_ampdu_request()`, then the function ends up > calling `ic->ic_send_action` (`ieee80211_send_action()`) with category > `IEEE80211_ACTION_CAT_BA` and action `IEEE80211_ACTION_BA_ADDBA_REQUEST`. > But then `ieee80211_send_action()` call the dummy function `send_inval()` > which does nothing. So net80211(4) doesn't send ADDBA requests for us. > > The same thing happens when RX an ADDBA request, net80211(4) doesn't reply > an ADDBA response to the transmitter. The only thing I found is that > net80211(4) has the `ieee80211_send_bar()` which does send BA requests > (which is not ADDBA request) for us. I wonder if there is something I'm > missing or if the "TX/RX ADDBA request/response" is handling most in > driver/firmware? > > Additionally, if I would like to test the 802.11n part in net80211(4), > which driver/device is suggested to use? Thanks. > [-- Attachment #2 --] <div dir="ltr">hi!<div><br></div><div>So, ampdu_request doesn't send addba itself. It calls ic_send_action because some NICs want a firmware message to start AMPDU, not sending frames.</div><div><br></div><div>Look at what ath(4) is doing. It registers for ic_send_action and that sends the actual frames.</div><div><br></div><div>mwl(4) (an old 11n marvell chipset, the first with freebsd 11n support) instead uses a firmware message.</div><div><br></div><div><br></div><div>-adrin</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, 4 Jul 2023 at 01:03, 吳恩緯 <<a href="mailto:rickywu0421@gmail.com">rickywu0421@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi,<br><br>I'm working on 14.0-CURRENT, and I found that it seems net80211(4) lack of supporting 802.11n/e TX ADDBA request:<br>When we call `ieee80211_ampdu_request()`, then the function ends up calling `ic->ic_send_action` (`ieee80211_send_action()`) with category `IEEE80211_ACTION_CAT_BA` and action `IEEE80211_ACTION_BA_ADDBA_REQUEST`. But then `ieee80211_send_action()` call the dummy function `send_inval()` which does nothing. So net80211(4) doesn't send ADDBA requests for us.<br><br>The same thing happens when RX an ADDBA request, net80211(4) doesn't reply an ADDBA response to the transmitter. The only thing I found is that net80211(4) has the `ieee80211_send_bar()` which does send BA requests (which is not ADDBA request) for us. I wonder if there is something I'm missing or if the "TX/RX ADDBA request/response" is handling most in driver/firmware?<br><br>Additionally, if I would like to test the 802.11n part in net80211(4), which driver/device is suggested to use? Thanks. <br><div></div></div> </blockquote></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmomeatKb0kWnfRjvr6FH-BD5BLG090dVzkDjdfBbOtQuPQ>