Date: Thu, 20 Sep 2018 09:23:21 -0700 From: Mark Millard <marklmi@yahoo.com> To: Mark Johnston <markj@FreeBSD.org>, svn-src-head@freebsd.org Subject: Re: svn commit: r336299 - in head: include lib/msun lib/msun/ld128 lib/msun/ld80 lib/msun/man lib/msun/src Message-ID: <EC459786-9C7E-4898-ACF2-A1A3E7393F9C@yahoo.com>
index | next in thread | raw e-mail
Mark Johnston markj at freebsd.org wrote on Thu Sep 20 15:54:08 UTC 2018 : > On Sun, Jul 15, 2018 at 12:23:11AM +0000, Matt Macy wrote: > > Author: mmacy > > Date: Sun Jul 15 00:23:10 2018 > > New Revision: 336299 > > URL: https://svnweb.freebsd.org/changeset/base/336299 > > > > Log: > > msun: add ld80/ld128 powl, cpow, cpowf, cpowl from openbsd > > > > This corresponds to the latest status (hasn't changed in 9+ > > years) from openbsd of ld80/ld128 powl, and source cpowf, cpow, > > cpowl (the complex power functions for float complex, double > > complex, and long double complex) which are required for C99 > > compliance and were missing from FreeBSD. Also required for > > some numerical codes using complex numbered Hamiltonians. > > > > Thanks to jhb for tracking down the issue with making > > weak_reference compile on powerpc. > > > > When asked to review, bde said "I don't like it" - but > > provided no actionable feedback or superior implementations. > > > > Discussed with: jhb > > Submitted by: jmd > > Differential Revision: https://reviews.freebsd.org/D15919 > > This seems to have broken the gcc build: > https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc/ > > /workspace/src/lib/msun/ld80/e_powl.c:275:1: error: floating constant exceeds range of 'long double' [-Werror=overflow] > if( y >= LDBL_MAX ) Building with a more recent vintage of the devel/amd64-gcc port does not do this (devel/powerpc64-=gcc master port). I've built locally multiple-times since the below that has by John Baldwin: QUOTE Revision 475290 - Directory Listing Modified Wed Jul 25 00:50:53 2018 UTC (8 weeks, 1 day ago) by jhb Drop builtin float.h for amd64-gcc. GCC's builtin <float.h> header is not compatible with sys/x86/include/float.h. Drop the builtin header for now. If at some point GCC's notion of floating point constants for i386 can converge with sys/x86/include/float.h this can be restored. Reviewed by: bapt Differential Revision: https://reviews.freebsd.org/D16073 END QUOTE Until ci.freebsd.org updates to be based on a version that includes the change the issue will exists there. There was activity on svn-src-head and freebsd-current starting back on 2018-Jun-28 that reported the issue and lead to the change, with subject: head -r335782 (?) broke ci.freebsd.org's FreeBSD-head-amd64-gcc build (lib32 part of build) === Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EC459786-9C7E-4898-ACF2-A1A3E7393F9C>