Date: Tue, 08 Jun 2004 21:01:02 -0500 From: "Jeremy Messenger" <mezz7@cox.net> To: "Adam Weinberger" <adamw@freebsd.org> Cc: freebsd-gnome@freebsd.org Subject: Re: Need feedback/review, a big change in AbiWord2 port. Message-ID: <opr9a070v19aq2h7@mezz> In-Reply-To: <20040609003811.GC72578@toxic.magnesium.net> References: <opr89h2ul39aq2h7@mezz> <20040608175318.GY72578@toxic.magnesium.net> <opr9ag46nu9aq2h7@mezz> <20040608185934.GB72578@toxic.magnesium.net> <opr9aicro99aq2h7@mezz> <20040609003811.GC72578@toxic.magnesium.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 8 Jun 2004 20:38:11 -0400, Adam Weinberger <adamw@FreeBSD.org>
wrote:
>>> (06.08.2004 @ 1513 PST): Jeremy Messenger said, in 3.8K: <<
>> >>>> - Change the default spell from Enchant to Aspell, because it
>> doesn't
>> >>>> work at all unless you compile Enchant with the Aspell support. I
>> >>>> think, it's waste to depend on Enchant by default.
>> >>>>
>> >>>> Also, I have removed the check of Enchant. I prefer to see force
>> >>>> user to want use Enchant if they know what to do with it. I need
>> >>>> the
>> >>>> help on write the better comment in @${ECHO_CMD} about this.
>> >>>
>> >>>I disagree strongly with this. I think that Enchant is a great idea.
>> >>>Enchant isn't being utilized properly ATM, but it has the propensity
>> to
>> >>>be a great leap forward in i18n spell-checking.
>> >>
>> >>What's your best suggest then? Force Enchant to compile with Aspell
>> >>support? This is the way that I will allow Enchant to be default. It
>> >>doesn't make any sense to have something that will not work by
>> default.
>> >>I
>> >>think, it's important to have the default that is just work.
>> >
>> >Enchant should theoretically work fine without aspell support. But, I
>> >think that Enchant should be enabled by defaultm, and should work
>> >out-of-the-box, by whatever means necessary.
>>
>> Do you mean, you think we should change Enchant port to compile with
>> Aspell support? If no, then I will not switch Aspell to Enchant for the
>> default spell, unless you have anything to fix it.
>>> end of "Re: Need feedback/review, a big change in AbiWord2 port." from
>>> Jeremy Messenger <<
>
> Yes. If Enchant needs aspell support for AbiWord2 to work best, then
> Enchant should depend upon aspell by default.
With those diffs, now the spell works by default with Enchant. No object
tonight and I will commit those by tomorrow. Thanks for review/feedback,
marcus and adamw!
http://people.freebsd.org/~mezz/diff/enchant.diff
http://people.freebsd.org/~mezz/diff/AbiWord2.diff
Cheers,
Mezz
> # Adam
>
>
> --
> Adam Weinberger
> adamw@magnesium.net || adamw@FreeBSD.org
> adamw@vectors.cx || adamw@gnome.org
> http://www.vectors.cx
--
mezz7@cox.net - mezz@FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?opr9a070v19aq2h7>