Date: Sun, 12 Dec 1999 23:47:36 +0800 From: Peter Wemm <peter@netplex.com.au> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: Kevin Street <street@iname.com>, "Jordan K. Hubbard" <jkh@zippy.cdrom.com>, FUJISHIMA Satsuki <k5@cheerful.com>, Greg Lehey <grog@lemis.com>, current@FreeBSD.ORG Subject: Re: vinum start needs block device Message-ID: <19991212154736.8295D1CA0@overcee.netplex.com.au> In-Reply-To: Message from Poul-Henning Kamp <phk@critter.freebsd.dk> of "Sun, 12 Dec 1999 16:37:29 %2B0100." <17568.945013049@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
Poul-Henning Kamp wrote:
> In message <879030896x.fsf@mired.eh.local>, Kevin Street writes:
>
> >Jordan, I don't understand your answer. Using the new MAKEDEV is what
> >causes vinum to fail. Won't -release be using the new MAKEDEV?
> >
> >Greg, is there a mechanism to transition an existing vinum
> >installation to the new device nodes?
>
> I think that between the two of us, Greg and I have lost a oneline
> patch on the floor, try this:
I tried a patch exactly like this last night, it works fine. I also
changed the error message below to say "not a _disk_ device" rather than
refer to block devices.
> Index: vinumio.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/dev/vinum/vinumio.c,v
> retrieving revision 1.45
> diff -u -r1.45 vinumio.c
> --- vinumio.c 1999/10/13 03:17:59 1.45
> +++ vinumio.c 1999/12/12 11:00:12
> @@ -76,7 +76,7 @@
> drive->devicename,
> drive->vp->v_usecount);
> }
> - if (drive->vp->v_type != VBLK) { /* only consider bl
ock devices */
> + if (!vn_isdisk(drive->vp)) { /* only consider bl
ock devices */
> VOP_UNLOCK(drive->vp, 0, drive->p);
> close_drive(drive);
> drive->lasterror = ENOTBLK;
>
> --
> Poul-Henning Kamp FreeBSD coreteam member
> phk@FreeBSD.ORG "Real hackers run -current on their laptop."
> FreeBSD -- It will take a long time before progress goes too far!
>
>
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-current" in the body of the message
>
>
Cheers,
-Peter
--
Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19991212154736.8295D1CA0>