Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 15 Sep 2011 21:25:19 -0400
From:      Arnaud Lacombe <lacombar@gmail.com>
To:        FreeBSD-Current <freebsd-current@freebsd.org>, freebsd-net@freebsd.org
Subject:   Queue drop not accounted ?
Message-ID:  <CACqU3MWYa7awOO0x1jPNyXq2gccYAL%2B5wzkE6nOqsNGdP0GyeA@mail.gmail.com>

next in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]
Hi,

Shouldn't packet freed in IFQ_ENQUEUE() because the queue is full be
accounted as dropped, cf attached patch ?

Thanks,
 - Arnaud

[-- Attachment #2 --]
diff --git a/sys/net/if_var.h b/sys/net/if_var.h
index 2dcb6f9..387f614 100644
--- a/sys/net/if_var.h
+++ b/sys/net/if_var.h
@@ -419,6 +419,7 @@ do {									\
 		ALTQ_ENQUEUE(ifq, m, NULL, err);			\
 	else {								\
 		if (_IF_QFULL(ifq)) {					\
+			_IF_DROP(ifq);					\
 			m_freem(m);					\
 			(err) = ENOBUFS;				\
 		} else {						\

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACqU3MWYa7awOO0x1jPNyXq2gccYAL%2B5wzkE6nOqsNGdP0GyeA>