Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 7 Aug 2007 23:10:30 GMT
From:      "Constantine A. Murenin" <cnst@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 124852 for review
Message-ID:  <200708072310.l77NAUuG043226@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=124852

Change 124852 by cnst@dale on 2007/08/07 23:09:30

	KNF

Affected files ...

.. //depot/projects/soc2007/cnst-sensors/sbin.sysctl/sysctl.c#3 edit

Differences ...

==== //depot/projects/soc2007/cnst-sensors/sbin.sysctl/sysctl.c#3 (text+ko) ====

@@ -143,7 +143,7 @@
 	if (Nflag && nflag)
 		usage();
 	if (aflag && argc == 0)
-		exit(sysctl_all(0, 0));
+		exit(sysctl_all(NULL, 0));
 	if (argc == 0)
 		usage();
 	while (argc-- > 0)
@@ -719,8 +719,8 @@
 	name1[0] = 0;
 	name1[1] = 2;
 	l1 = 2;
-	if (len) {
-		memcpy(name1+2, oid, len * sizeof(int));
+	if (len > 0) {
+		memcpy(name1 + 2, oid, len * sizeof(int));
 		l1 += len;
 	} else {
 		name1[2] = 1;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200708072310.l77NAUuG043226>