Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 25 Nov 2008 11:25:45 +0000 (UTC)
From:      Robert Watson <rwatson@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r185293 - head/sys/security/audit
Message-ID:  <200811251125.mAPBPj6B018481@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: rwatson
Date: Tue Nov 25 11:25:45 2008
New Revision: 185293
URL: http://svn.freebsd.org/changeset/base/185293

Log:
  Regularize /* FALLTHROUGH */ comments in the BSM event type switch, and
  add one that was missing.
  
  MFC after:	3 weeks
  Coverity ID:	3960

Modified:
  head/sys/security/audit/audit_bsm.c

Modified: head/sys/security/audit/audit_bsm.c
==============================================================================
--- head/sys/security/audit/audit_bsm.c	Tue Nov 25 09:49:05 2008	(r185292)
+++ head/sys/security/audit/audit_bsm.c	Tue Nov 25 11:25:45 2008	(r185293)
@@ -589,7 +589,7 @@ kaudit_to_bsm(struct kaudit_record *kar,
 			tok = au_to_arg32(1, "cmd", ar->ar_arg_cmd);
 			kau_write(rec, tok);
 		}
-		/* fall thru */
+		/* FALLTHROUGH */
 
 	case AUE_AUDITON_GETCAR:
 	case AUE_AUDITON_GETCLASS:
@@ -662,7 +662,8 @@ kaudit_to_bsm(struct kaudit_record *kar,
 			tok = au_to_arg32(2, "mode", ar->ar_arg_mode);
 			kau_write(rec, tok);
 		}
-		/* fall through */
+		/* FALLTHROUGH */
+
 	case AUE_ACCESS:
 	case AUE_CHDIR:
 	case AUE_CHROOT:
@@ -877,7 +878,8 @@ kaudit_to_bsm(struct kaudit_record *kar,
 			tok = au_to_arg32(1, "flags", ar->ar_arg_fflags);
 			kau_write(rec, tok);
 		}
-		/* fall through */
+		/* FALLTHROUGH */
+
 	case AUE_FORK:
 	case AUE_VFORK:
 		if (ARG_IS_VALID(kar, ARG_PID)) {
@@ -1013,7 +1015,7 @@ kaudit_to_bsm(struct kaudit_record *kar,
 			tok = au_to_text(ar->ar_arg_text);
 			kau_write(rec, tok);
 		}
-		/* fall through */
+		/* FALLTHROUGH */
 
 	case AUE_UMOUNT:
 		UPATH1_VNODE1_TOKENS;
@@ -1062,7 +1064,7 @@ kaudit_to_bsm(struct kaudit_record *kar,
 			tok = au_to_arg32(3, "mode", ar->ar_arg_mode);
 			kau_write(rec, tok);
 		}
-		/* fall through */
+		/* FALLTHROUGH */
 
 	case AUE_OPEN_R:
 	case AUE_OPEN_RT:
@@ -1339,6 +1341,8 @@ kaudit_to_bsm(struct kaudit_record *kar,
 			tok = au_to_arg32(3, "mode", ar->ar_arg_mode);
 			kau_write(rec, tok);
 		}
+		/* FALLTHROUGH */
+
 	case AUE_SHMUNLINK:
 		if (ARG_IS_VALID(kar, ARG_TEXT)) {
 			tok = au_to_text(ar->ar_arg_text);
@@ -1372,7 +1376,7 @@ kaudit_to_bsm(struct kaudit_record *kar,
 			tok = au_to_arg32(4, "value", ar->ar_arg_value);
 			kau_write(rec, tok);
 		}
-		/* fall through */
+		/* FALLTHROUGH */
 
 	case AUE_SEMUNLINK:
 		if (ARG_IS_VALID(kar, ARG_TEXT)) {

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200811251125.mAPBPj6B018481>