Date: Sat, 15 Apr 1995 17:57:05 -0700 From: Paul Traina <pst@shockwave.com> To: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com> Cc: bde@zeta.org.au (Bruce Evans), CVS-commiters@freefall.cdrom.com, bde@freefall.cdrom.com, cvs-usrsbin@freefall.cdrom.com Subject: Re: cvs commit: src/usr.sbin/bad144 bad144.c Message-ID: <199504160057.RAA02447@precipice.shockwave.com> In-Reply-To: Your message of "Sat, 15 Apr 1995 16:35:54 PDT." <199504152335.QAA05684@gndrsh.aac.dev.com>
next in thread | previous in thread | raw e-mail | index | archive | help
We originally put it in because twits had the habbit of doing:
CSCdi12398438: this is a bug fix for
killing ants
instead of:
CSCdi12394848: this is a bug fix for
killing ants
which made our log files look ugly.
From: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com>
Subject: Re: cvs commit: src/usr.sbin/bad144 bad144.c
>
> > - Avoid overflow in calculation of lseek() offsets.
> > - Fix format args in strings some more. %ld and %lu were often reversed
>> and
> > #ifdefed out strings weren't fixed.
> > - Don't hard code the raw partition letter or DKBAD*.
>
> Why does cvs strip leading whitspace in log messages? The `#ifdefed' line
> is supposed to be indented.
Becuase who ever wrote log_accum.pl thought that is what it should do:
#
# Iterate over the body of the message collecting information.
#
while (<STDIN>) {
chop; # Drop the newline
if (/^Modified Files/) { $state = $STATE_CHANGED; next; }
if (/^Added Files/) { $state = $STATE_ADDED; next; }
if (/^Removed Files/) { $state = $STATE_REMOVED; next; }
if (/^Log Message/) { $state = $STATE_LOG; next; }
s/^[ \t\n]+//; # delete leading space
s/[ \t\n]+$//; # delete trailing space
push (@changed_files, split) if ($state == $STATE_CHANGED);
push (@added_files, split) if ($state == $STATE_ADDED);
push (@removed_files, split) if ($state == $STATE_REMOVED);
push (@log_lines, $_) if ($state == $STATE_LOG);
}
I need a concenses on this, but I am willing to delete the line
that removes the leading space, it has annoyed me on several occasions.
--
Rod Grimes rgrimes@gndrsh.aac.dev.com
Accurate Automation Company Custom computers for FreeBSD
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199504160057.RAA02447>