Date: Mon, 16 Mar 2020 21:41:30 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 243857] New Port: /sysutils/xdisk - a partition editor Message-ID: <bug-243857-7788-dxXCZp4fWJ@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-243857-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-243857-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243857 Adam Weinberger <adamw@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adamw@FreeBSD.org --- Comment #7 from Adam Weinberger <adamw@FreeBSD.org> --- This program looks cool! Some issues: 1) Why is this pulling a single file out of source control? That doesn't se= em ideal. There's no guarantee that that file won't change or disappear in any future commit. Also it seems strange that people checking out from git shou= ld have to download tarballs. Ideally it should be pulling a tag, or a file fr= om releases. 2) All the args to ${INSTALL_PROGRAM} are unnecessary (and the mode is wrong---binaries should be installed 555, as they are by default, and not 7= 55). root:wheel and mode 555 happens automatically. And while we're here: no sla= sh needed after ${STAGEDIR} (${LOCALBASE} starts with a /): ${STAGEDIR}${LOCALBSE}/... 3) The upstream Makefile hardcodes /usr/local, which need to be substituted. See https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/slow-pat= ch.html#slow-patch-automatic-replacements 4) Ideally, the Makefile should be getting the glib/gtk/cairo/pango/etc. fr= om pkg-config, not by hardcoding. That's up to developer preference but we'd certainly urge it. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-243857-7788-dxXCZp4fWJ>