Date: Fri, 9 Apr 2021 01:07:00 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Alexander Lochmann <alexander.lochmann@tu-dortmund.de> Cc: freebsd-fs@freebsd.org Subject: Re: [struct mount] Outdated locking documentation for mnt_uppers Message-ID: <YG9%2BhGpGuF4PUR3s@kib.kiev.ua> In-Reply-To: <53c970ad-bd87-5d7b-8a6c-4e526d96b93b@tu-dortmund.de> References: <53c970ad-bd87-5d7b-8a6c-4e526d96b93b@tu-dortmund.de>
index | next in thread | previous in thread | raw e-mail
On Wed, Apr 07, 2021 at 09:50:18PM +0200, Alexander Lochmann wrote: > Hi folks, > > I came accross the locking documentation for struct mount. > According to the definition [1], mnt_uppers should be accessed using the > global mountlist_mtx. > However, the code uses the MNT_ILOCK macro, which uses the mnt_mtx. > Is the locking documentation still valid? > Shouldn't it be updated? Thank you for the report, done in 5af1131de7fc.help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YG9%2BhGpGuF4PUR3s>