Date: Mon, 11 Mar 2019 22:52:34 +0300 From: Vladimir Kondratyev <vladimir@kondratyev.su> To: Jung-uk Kim <jkim@freebsd.org> Cc: Ravi Pokala <rpokala@freebsd.org>, Vladimir Kondratyev <wulf@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344982 - head/sys/x86/isa Message-ID: <8335f06543bd6f4d2119d74f7f4df74f@kondratyev.su> In-Reply-To: <c7ad6dd0-5789-5e47-34c5-b33260f9845c@FreeBSD.org> References: <201903102019.x2AKJiJY029807@repo.freebsd.org> <00F61A40-C128-4F75-A45F-A6CECBB791C2@panasas.com> <c7ad6dd0-5789-5e47-34c5-b33260f9845c@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2019-03-11 21:17, Jung-uk Kim wrote: > On 19. 3. 11., Ravi Pokala wrote: >> -----Original Message----- >> From: <owner-src-committers@freebsd.org> on behalf of Vladimir >> Kondratyev <wulf@FreeBSD.org> >> Date: 2019-03-10, Sunday at 13:19 >> To: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, >> <svn-src-head@freebsd.org> >> Subject: svn commit: r344982 - head/sys/x86/isa >> >>> Author: wulf >>> Date: Sun Mar 10 20:19:43 2019 >>> New Revision: 344982 >>> URL: https://svnweb.freebsd.org/changeset/base/344982 >>> >>> Log: >>> atrtc(4): install ACPI RTC/CMOS operation region handler >> >> Hi Vladimir, >> >> This appears to have broken all the various LINT kernels for amd64 and >> i386: >> >> ================================================================ >> /usr/home/rpokala/freebsd/clean/base/head/sys/x86/isa/atrtc.c:321:2: >> error: use of undeclared identifier '_AcpiModuleName' >> ACPI_FUNCTION_TRACE((char *)(uintptr_t)__func__); >> ^ >> /usr/home/rpokala/freebsd/clean/base/head/sys/contrib/dev/acpica/include/acoutput.h:480:18: >> note: expanded from macro 'ACPI_FUNCTION_TRACE' >> AcpiUtTrace (ACPI_DEBUG_PARAMETERS) >> ^ >> /usr/home/rpokala/freebsd/clean/base/head/sys/contrib/dev/acpica/include/acoutput.h:402:39: >> note: expanded from macro 'ACPI_DEBUG_PARAMETERS' >> __LINE__, ACPI_GET_FUNCTION_NAME, _AcpiModuleName, _COMPONENT >> ^ >> /usr/home/rpokala/freebsd/clean/base/head/sys/x86/isa/atrtc.c:321:2: >> error: use of undeclared identifier '_COMPONENT' >> /usr/home/rpokala/freebsd/clean/base/head/sys/contrib/dev/acpica/include/acoutput.h:480:18: >> note: expanded from macro 'ACPI_FUNCTION_TRACE' >> AcpiUtTrace (ACPI_DEBUG_PARAMETERS) >> ^ >> /usr/home/rpokala/freebsd/clean/base/head/sys/contrib/dev/acpica/include/acoutput.h:402:56: >> note: expanded from macro 'ACPI_DEBUG_PARAMETERS' >> __LINE__, ACPI_GET_FUNCTION_NAME, _AcpiModuleName, _COMPONENT >> ^ >> ================================================================ >> >> That same pattern of errors is noted for lines 321, 362, and 386. >> >> Please take a look at your earliest convenience. > > Please try the attached patch. > > Jung-uk Kim Thank you! It fixed LINT at least on amd64. Sorry for breakage :-( -- WBR Vladimir Kondratyev
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8335f06543bd6f4d2119d74f7f4df74f>