Date: Wed, 21 Apr 2004 08:27:36 -0700 (PDT) From: Luigi Rizzo <luigi@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/net radix.c Message-ID: <200404211527.i3LFRabS088245@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
luigi 2004/04/21 08:27:36 PDT
FreeBSD src repository
Modified files:
sys/net radix.c
Log:
Readability fixes:
Clearly comment the assumptions on the structure of keys (addresses)
and masks, and introduce a macro, LEN(p), to extract the size of these
objects instead of using *(u_char *)p which might be confusing.
Comment the confusion in the types used to pass around pointers
to keys and masks, as a reminder to fix that at some point.
Add a few comments on what some functions do.
Comment a probably inefficient (but still correct) section of code
in rn_walktree_from()
The object code generated after this commit is the same as before.
At some point we should also change same variable identifiers such
as "t, tt, ttt" to fancier names such as "root, left, right" (just
in case someone wants to understand the code!), replace misspelling
of NULL as 0, remove 'register' declarations that make little sense
these days.
Revision Changes Path
1.36 +76 -12 src/sys/net/radix.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200404211527.i3LFRabS088245>