Date: Sat, 22 Jan 2000 00:42:27 -0800 (PST) From: hide@koie.org To: freebsd-gnats-submit@FreeBSD.org Subject: kern/16292: performance problem of divert socket Message-ID: <20000122084227.E65EE15558@hub.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 16292
>Category: kern
>Synopsis: performance problem of divert socket
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Jan 22 00:50:01 PST 2000
>Closed-Date:
>Last-Modified:
>Originator: KOIE Hidetaka
>Release: FreeBSD 3.3-RELEASE
>Organization:
>Environment:
FreeBSD skipjack.koie.org 3.3-RELEASE FreeBSD 3.3-RELEASE #0: Wed Dec 8 09:16:43 JST 1999 koie@skipjack.koie.org:/usr/src/sys/compile/TP i386
>Description:
In sys/netinet/ip_output.c,
ip_output() checks that ifnet::if_snd has room enough to
enqueue entire packet.
This verifying code is commited at revision 1.3.
But, using divert socket and IPFW,
on fire hose syndrome router,
user-land program (ipfw add divert N ... out xmit IFACE)
can not receive all packets.
/*
* Verify that we have any chance at all of being able to queue
* the packet or packet fragments
*/
if ((ifp->if_snd.ifq_len + ip->ip_len / ifp->if_mtu + 1) >=
ifp->if_snd.ifq_maxlen) {
error = ENOBUFS;
goto bad;
}
>How-To-Repeat:
>Fix:
IMHO, this verifing code should be moved to
the immediately following `pass:'.
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000122084227.E65EE15558>