Date: 22 Aug 2001 23:37:37 -0000 From: Joseph Mallett <jmallett@xMach.org> To: FreeBSD-gnats-submit@freebsd.org Cc: Joseph Mallett <jmallett@xMach.org> Subject: kern/29967: src/sys/net/bpf.c comments are incorrect Message-ID: <20010822233737.37868.qmail@mail.newgold.net>
next in thread | raw e-mail | index | archive | help
>Number: 29967 >Category: kern >Synopsis: bpf code has a misleading comment >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Wed Aug 22 16:40:27 PDT 2001 >Closed-Date: >Last-Modified: >Originator: Joseph Mallett >Release: FreeBSD 4.4-RC i386 >Organization: xMach >Environment: System: FreeBSD Aphex.NewGold.NET 4.4-RC FreeBSD 4.4-RC #0: Mon Aug 20 06:41:21 GMT 2001 jmallett@Aphex.NewGold.NET:/usr/people/jmallett/obj i386 >Description: Ever since some time in ancient history (4.4-lite?), the comment for bpfattach has been pretty incorrect when it comes to explaining what the parameters are. ifp is not explained, and driverp (which is no longer present in FreeBSD) is still explained. >How-To-Repeat: vi /sys/net/bpf.c :/bpfattach/ >Fix: --- bpf.orig Wed Aug 22 23:31:16 2001 +++ bpf.c Wed Aug 22 23:33:27 2001 @@ -1272,9 +1272,10 @@ } /* - * Attach an interface to bpf. driverp is a pointer to a (struct bpf_if *) - * in the driver's softc; dlt is the link layer type; hdrlen is the fixed - * size of the link header (variable length headers not yet supported). + * Attach an interface to bpf. ifp is a pointer to the structure defining + * the interface to be attached; dlt is the link layer type; hdrlen is the + * fixed size of the link header (variable length headers are not + * supported, yet.) */ void bpfattach(ifp, dlt, hdrlen) >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010822233737.37868.qmail>