Date: Tue, 27 May 2025 06:04:29 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: MANTANI Nobutaka <nobutaka@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 4e186c681084 - main - editors/microsoft-edit: New port, a console text editor written in Rust Message-ID: <aDVV7fgYhsNtwQET@FreeBSD.org> In-Reply-To: <202505261700.54QH0rn2007874@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
On Mon, May 26, 2025 at 05:00:53PM +0000, MANTANI Nobutaka wrote:
> commit 4e186c681084fc2996f98ed6927b2536bd13d495
>
> editors/microsoft-edit: New port, a console text editor written in Rust
> ...
> +post-install:
> + ${LN} -sf ${PREFIX}/bin/edit ${STAGEDIR}/${PREFIX}/bin/msedit
There are several bugs in this line. First, symlink target should rarely be
an absolute path (imagine mounting this filesystem under different path --
the link would get broken). Second, you don't need to specify any path at
all as both source and target sit in the same directory. Third, for the
same reason, you could hardlink instead and save an inode. Fourth, there is
a superfluous slash between ${STAGEDIR} and ${PREFIX}.
./danfe
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aDVV7fgYhsNtwQET>