Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 3 Jul 2018 08:50:50 +0000 (UTC)
From:      Kristof Provost <kp@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r335886 - head/sbin/pfctl
Message-ID:  <201807030850.w638ooDb020648@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kp
Date: Tue Jul  3 08:50:49 2018
New Revision: 335886
URL: https://svnweb.freebsd.org/changeset/base/335886

Log:
  pfctl: Don't retrieve interface list if '-n' is set
  
  If '-n' is set we don't use the list of skip interfaces, so don't retrieve it.
  This fixes issues if 'pfctl -n' is used before the pf module is loaded. This
  was broken by r333181.
  
  Reported by:	Jakub Chromy <hicks AT cgi.cz>
  MFC after:	1 week

Modified:
  head/sbin/pfctl/pfctl.c

Modified: head/sbin/pfctl/pfctl.c
==============================================================================
--- head/sbin/pfctl/pfctl.c	Tue Jul  3 08:44:40 2018	(r335885)
+++ head/sbin/pfctl/pfctl.c	Tue Jul  3 08:50:49 2018	(r335886)
@@ -2409,7 +2409,7 @@ main(int argc, char *argv[])
 	}
 
 	if ((rulesopt != NULL) && (loadopt & PFCTL_FLAG_OPTION) &&
-	    !anchorname[0])
+	    !anchorname[0] && !(opts & PF_OPT_NOACTION))
 		if (pfctl_get_skip_ifaces())
 			error = 1;
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201807030850.w638ooDb020648>