Date: Fri, 12 Apr 2002 12:12:12 -0400 From: Mike Barcroft <mike@FreeBSD.ORG> To: Ruslan Ermilov <ru@FreeBSD.ORG> Cc: Dag-Erling Smorgrav <des@FreeBSD.ORG>, current@FreeBSD.ORG, "David O'Brien" <obrien@FreeBSD.ORG> Subject: Re: alpha tinderbox failure Message-ID: <20020412121212.E28249@espresso.q9media.com> In-Reply-To: <20020412135421.GC27751@sunbay.com>; from ru@FreeBSD.ORG on Fri, Apr 12, 2002 at 04:54:21PM %2B0300 References: <200204111654.g3BGsmc9069057@beast.freebsd.org> <20020412135421.GC27751@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Ruslan Ermilov <ru@FreeBSD.ORG> writes:
> I see the same breakage here.
>
> The breakage has nothing to do with -Werror. Recent commit by
> Mike Barcroft to sys/*/endian.h is the culprit.
>
> But the actual problem is with gdb. After a lot of experimenting
> I've found that contrib/gdb.291/gdb/defs.h includes "nm.h"
> (gnu/usr.bin/binutils/gdb/${MACHINE_ARCH}/nm.h) which are too
> different between i386 and alpha. In the i386 case, "nm.h"
> includes <sys/types.h> which exposes __BSD_VISIBLE (see how
> these affect the *_ENDIAN macros in sys/*/endian.h). But not
> in the alpha case. Applying this patch exposes the same bug
> on i386:
>
[...]
David added <sys/types.h> to src/gnu/usr.bin/binutils/gdb/alpha/nm.h
19 hours ago, so the problem should no longer exist. I won't know for
another three hours (when my alpha is finished buildworld).
> The solution is to fix defs.h:
>
> %%%
> Index: defs.h
> ===================================================================
> RCS file: /home/ncvs/src/contrib/gdb.291/gdb/defs.h,v
> retrieving revision 1.3
> diff -u -p -r1.3 defs.h
> --- defs.h 11 Apr 2001 16:15:19 -0000 1.3
> +++ defs.h 12 Apr 2002 13:53:37 -0000
> @@ -841,6 +841,8 @@ extern void free ();
>
> #ifdef HAVE_ENDIAN_H
> #include <endian.h>
> +#else
> +#include <sys/types.h>
> #endif
>
> #if !defined (BIG_ENDIAN)
> %%%
I think <machine/endian.h> would be better here. It may not have
worked because of the missing <sys/cdefs.h> issue.
Sorry about the breakage.
Best regards,
Mike Barcroft
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020412121212.E28249>