Date: Tue, 5 Jul 2016 11:54:20 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Dimitry Andric <dim@FreeBSD.org> Cc: freebsd-current@FreeBSD.org, Roman Divacky <rdivacky@FreeBSD.org> Subject: Re: FreeBSD_HEAD_amd64_gcc - Build #1340 - Still Failing Message-ID: <AB8350C8-7CEF-4559-828D-9D78BE7B24A6@gmail.com> In-Reply-To: <1A4CCE99-7039-404C-B177-1DA230AD8811@FreeBSD.org> References: <74935894.29.1467723929184.JavaMail.jenkins@jenkins-9.freebsd.org> <824400089.31.1467734600930.JavaMail.jenkins@jenkins-9.freebsd.org> <1A4CCE99-7039-404C-B177-1DA230AD8811@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Jul 5, 2016, at 11:52, Dimitry Andric <dim@FreeBSD.org> wrote: > > On 05 Jul 2016, at 18:03, jenkins-admin@freebsd.org wrote: >> >> FreeBSD_HEAD_amd64_gcc - Build #1340 - Still Failing: >> >> Build information: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_amd64_gcc/1340/ >> Full change log: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_amd64_gcc/1340/changes >> Full build log: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_amd64_gcc/1340/console > ... >> /builds/FreeBSD_HEAD_amd64_gcc/usr.sbin/bhyve/rfb.c: In function 'sse42_supported': >> /builds/FreeBSD_HEAD_amd64_gcc/usr.sbin/bhyve/rfb.c:885:17: error: 'bit_SSE42' undeclared (first use in this function) >> return ((ecx & bit_SSE42) != 0); >> ^ > > So, this is because clang's and gcc's versions of cpuid.h use slightly different naming for these bits: > > clang's cpuid.h: > > #define bit_SSE41 0x00080000 > #define bit_SSE42 0x00100000 > > gcc's cpuid.h: > > #define bit_SSE4_1 (1 << 19) > #define bit_SSE4_2 (1 << 20) > > Unfortunately there are more bit defines that differ. No standardization on this point, it seems. :-/ > > For this specific compile error, we could put in a little crutch like: > > #if defined(bit_SSE4_2) && !defined(bit_SSE42) > #define bit_SSE42 bit_SSE4_2 > #endif > > Thoughts? Seems ok to me. I was going to submit a patch to fix the other issues with bhyve (because I am getting annoyed by the build failure emails). Thanks, -Ngie [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJXfAJcAAoJEPWDqSZpMIYVp9kQALz7EnMgxqQqVdVTXNt1o3gs iOQZBOmM+MMDhFVS40rfIH+PezScqvcfq8e25buz8k8a/dj4tEOKHkxdGptoLqHt K0gUJad11QZFNc8L5uNdakb1LXbIKAOIMfv9aK1AZxPcYZBqsoWdGDyjMCL1dtM7 NK6pbDmJf4gjZ0OCJ7rQ19+1dO5z4Yc3feu+G8Hinjx0H7UYIQ8SbNyht6iOsX8P VKLZ/PMy3iV1/Sxf5WP7GvDlE7qun8tUV3Ajn1I5GDQQlFuP5+s16OwePkyCc0i8 DwvdecuZD4VlsdKdYHULz7Ywnv/k7NWSbbd7mX7fX7rlnPPDfpjVAqHWjWhxVbEI ZvVv2VHiBKGiCUj6ON5tB3ob4IiOKgqwzkeE1QE6diaxwniD0LbsTbztuCE9FPix H6n5U4f6uSg4QvF7jand4ifVgSix6m1TeTTI6FqdFfQ84pnHTfzU/xfvtOUmCXyg sA6Lb/Qb+GVzrTBWzlLk72tDUCGzCbFwdOV9LNwvqDFKVm7qGc0psiW4G/XMgf4j CiqKulaq3PFKm1wXj5HU9o/+ggWyYE6iWICZ8dyPHrmPRDsO6MJKnZyRjX55WqQh LZdhaH6MB0W99SAwyoRUHP9LGvTZbdAzDpGGn4ZbDCOGgUcuRmUtJ71Lt15DAdhG 3X+/H7ZfKIyPeTGeX6K7 =7xpE -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AB8350C8-7CEF-4559-828D-9D78BE7B24A6>