Date: Sun, 5 Jan 2014 21:37:21 -0800 From: Adrian Chadd <adrian@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r260363 - head/sys/dev/ath Message-ID: <CAJ-VmomRefeAdd_VdRO8Q8jTpC2hbC7Q22vy_uJB7FX=OUUFLQ@mail.gmail.com> In-Reply-To: <20140106035139.GC59496@kib.kiev.ua> References: <201401060348.s063mW8C031852@svn.freebsd.org> <20140106035139.GC59496@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 5 January 2014 19:51, Konstantin Belousov <kostikbel@gmail.com> wrote: > On Mon, Jan 06, 2014 at 03:48:32AM +0000, Adrian Chadd wrote: >> Author: adrian >> Date: Mon Jan 6 03:48:32 2014 >> New Revision: 260363 >> URL: http://svnweb.freebsd.org/changeset/base/260363 >> >> Log: >> Correctly remove entries from the relevant receive ath_buf list before >> freeing them. >> >> The current code would walk the list and call the buffer free, which >> didn't remove it from any lists before pushing it back on the free list. >> >> Tested: AR9485, STA mode >> >> Noticed by: dillon@apollo.dragonflybsd.org > This is a NOP, right ? Nope. the previous version didn't remove the entries from the list. that's the bug. -a
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmomRefeAdd_VdRO8Q8jTpC2hbC7Q22vy_uJB7FX=OUUFLQ>