Date: Tue, 27 Nov 2012 23:05:39 +0000 From: "Robert N. M. Watson" <rwatson@FreeBSD.org> To: Andre Oppermann <andre@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Peter Wemm <peter@wemm.org> Subject: Re: svn commit: r243627 - head/sys/kern Message-ID: <956CE44A-BA0F-4FE4-AA38-F4B90C85ECBA@FreeBSD.org> In-Reply-To: <50B54492.5040100@freebsd.org> References: <201211272004.qARK4qS8047209@svn.freebsd.org> <CAGE5yCpxOdsjefe6quR_gjs82pk9a2e_H_WUNUWhUGA3WZPJaw@mail.gmail.com> <50B54180.5020608@freebsd.org> <alpine.BSF.2.00.1211272246560.37292@fledge.watson.org> <50B54492.5040100@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 27 Nov 2012, at 22:54, Andre Oppermann wrote: >>>> Andre.. this breaks incoming connections. TCP is immediately reset = and never even gets to the >>>> listener process. You need to back out of fix this urgently = please. >>>=20 >>> I just found out and fixed it. Sorry for the breakage. >>=20 >> I'd like to see a much more thorough use of "Reviewed by:" in socket = and TCP-related commits -- this >> is very sensitive code, and a second pair of eyes is always valuable. = Post-commit review is not a >> substitute. Looking back over similar changes in the socket code = over the last two years, I see >> that almost all have reviewers, so I think it would be reasonable to = consider it mandatory for these >> subsystems at this point. The good news is that we have lots of = people with expertise in it. >=20 > Good to see you becoming more active again. :-) And yes, > you have a point there. Yes -- this is only about three weeks old, however; for the prior = six-twelve months, I've been fairly non-existent in FreeBSD-land due to = outside obligations :-). Robert=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?956CE44A-BA0F-4FE4-AA38-F4B90C85ECBA>