Date: Tue, 16 Dec 2008 11:06:31 +0000 (UTC) From: Kip Macy <kmacy@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r186178 - head/sys/netinet Message-ID: <200812161106.mBGB6VAI036056@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: kmacy Date: Tue Dec 16 11:06:30 2008 New Revision: 186178 URL: http://svn.freebsd.org/changeset/base/186178 Log: ipfw doesn't use the radix node head lock to protect the radix tree - remove acquisition Modified: head/sys/netinet/ip_fw2.c Modified: head/sys/netinet/ip_fw2.c ============================================================================== --- head/sys/netinet/ip_fw2.c Tue Dec 16 11:04:02 2008 (r186177) +++ head/sys/netinet/ip_fw2.c Tue Dec 16 11:06:30 2008 (r186178) @@ -1827,9 +1827,7 @@ add_table_entry(struct ip_fw_chain *ch, ent->mask.sin_addr.s_addr = htonl(mlen ? ~((1 << (32 - mlen)) - 1) : 0); ent->addr.sin_addr.s_addr = addr & ent->mask.sin_addr.s_addr; IPFW_WLOCK(ch); - RADIX_NODE_HEAD_LOCK(rnh); rn = rnh->rnh_addaddr(&ent->addr, &ent->mask, rnh, (void *)ent); - RADIX_NODE_HEAD_UNLOCK(rnh); if (rn == NULL) { IPFW_WUNLOCK(ch); free(ent, M_IPFW_TBL);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200812161106.mBGB6VAI036056>