Date: Sat, 4 Oct 2025 17:16:30 -0600 From: Warner Losh <imp@bsdimp.com> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: current@freebsd.org Subject: Re: svnlite code in Makefile.inc1 still needed? Message-ID: <CANCZdfrY_AtdOjXvi4LRbFbOHLv-QhBCe52zjUuH4qdLKPmdQw@mail.gmail.com> In-Reply-To: <91r7p6r9-5qos-31qo-64o0-p4r0q2p1opsr@mnoonqbm.arg>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Sat, Oct 4, 2025 at 2:37 PM Bjoern A. Zeeb < bzeeb-lists@lists.zabbadoz.net> wrote: > Hi, > > I beleive there might be a $ too much in two lines or the arguemnts are > not properly shell quoted or something? > > make[7]: /usr/src/src.git/Makefile.inc1:526: warning: Invalid character " > " in variable name "eval /usr/bin/svnliteversion /usr/src/src.git" > make[7]: /usr/src/src.git/Makefile.inc1:526: warning: Invalid character " > " in variable name "echo r" > > Makes me wonder if svnliteversion magic is still needed? > No. It's unused. And a bit of a nop these days unless you happen to have svn still installed. I never see this error, though. Which shell are you using? https://reviews.freebsd.org/D52912 removes it. Warner [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Sat, Oct 4, 2025 at 2:37 PM Bjoern A. Zeeb <<a href="mailto:bzeeb-lists@lists.zabbadoz.net">bzeeb-lists@lists.zabbadoz.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br> <br> I beleive there might be a $ too much in two lines or the arguemnts are not properly shell quoted or something?<br> <br> make[7]: /usr/src/src.git/Makefile.inc1:526: warning: Invalid character " " in variable name "eval /usr/bin/svnliteversion /usr/src/src.git"<br> make[7]: /usr/src/src.git/Makefile.inc1:526: warning: Invalid character " " in variable name "echo r"<br> <br> Makes me wonder if svnliteversion magic is still needed?<br></blockquote><div><br></div><div>No. It's unused. And a bit of a nop these days unless you happen to have svn still installed. I never see this error, though. Which shell are you using?</div><div><br></div><div><a href="https://reviews.freebsd.org/D52912">https://reviews.freebsd.org/D52912</a>; removes it.</div><div><br></div><div>Warner </div></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrY_AtdOjXvi4LRbFbOHLv-QhBCe52zjUuH4qdLKPmdQw>