Date: Wed, 10 Feb 2010 15:50:22 +0300 From: Dmitry Marakasov <amdmi3@amdmi3.ru> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/audio Makefile ports/audio/deadbeef Makefile distinfo pkg-descr pkg-plist ports/audio/deadbeef/files patch-Makefile.am patch-Makefile.in patch-configure patch-configure.ac Message-ID: <20100210125022.GD1538@hades.panopticon> In-Reply-To: <20100210092407.GA30717@FreeBSD.org> References: <201002092323.o19NNRvB090976@repoman.freebsd.org> <20100210092407.GA30717@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* Alexey Dokuchaev (danfe@FreeBSD.org) wrote: > Fully qualified person id (full name) should be used when available > (Whom: line of Makefile header). > COMMENT= DeaDBeeF is an audio player for GNU/Linux systems with X11 > ^^^^^^^^^^^^ > Mentioning program name in COMMENT is redundant; simple "An audio > player..." would be enough. "GNU/Linux" also looks strange on BSD system. > "Unix[-like]" would be more appropriate. Thanks, will resolve both with the next update. > > 1.1 +13 -0 ports/audio/deadbeef/files/patch-Makefile.am (new) > > 1.1 +21 -0 ports/audio/deadbeef/files/patch-Makefile.in (new) > > Weird. Can you explain why both of these patches are required, since .in > is normally generated from .am (that is, patching .in is enough unless > the port needs more of autotools magic than simple "./configure")? Configure tends to rerun autotools when available sometimes, thus files gets regenerated, so to be on a safe side, sources are patched as well. Anyway, these patches will go away with the next update. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100210125022.GD1538>