Date: Wed, 30 Jul 2014 13:14:16 -0700 From: Cy Schubert <Cy.Schubert@komquats.com> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: Cy Schubert <Cy.Schubert@komquats.com>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Cy Schubert <cy@FreeBSD.org> Subject: Re: svn commit: r363477 - head/sysutils/cfengine36 Message-ID: <201407302014.s6UKEH45007297@slippy.cwsent.com> In-Reply-To: Message from Baptiste Daroussin <bapt@FreeBSD.org> of "Wed, 30 Jul 2014 18:43:35 %2B0200." <20140730164334.GL37672@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20140730164334.GL37672@ivaldir.etoilebsd.net>, Baptiste Daroussin w rites: > Here is a new attempt: > https://people.freebsd.org/~bapt/cfengine36.diff > > This version keep your initial m4 patch and regenerate the configure. > Because I wasn't able to regenerate properly with the bsd.autotools.mk framew > ork > I simply run the right autoreconf command in pre-configure target. > As USES=libtool patch target happens after pre-configure then the uses works > properly > > Which leads to proper building of the lib (and the .so.3 being correctly > created) > > INSTALL_TARGET=install-strip makes sure your binary are stripped > > the options helpers are simply cosmetics > > USES=pgsql is the new proper way to hangle dependencies on pgsql :) I understand what these do. In addition to not including a file (strndup.m4) referenced by aclocal.m4, seems they also broke libtool.sh in the process. Your patch circumvents the issue, which is why we needed to regenerate the configure scripts. It works. This saves me a bit of work tonight. Thanks! Just committed with complete doc. -- Cheers, Cy Schubert <Cy.Schubert@komquats.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201407302014.s6UKEH45007297>