Date: Tue, 23 Apr 2024 16:21:30 +0200 From: Gordon Bergling <gbe@freebsd.org> To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= <des@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 8993d785a261 - main - expand.1: Fix markup for the '-t' option Message-ID: <ZifD6uvvAbmB4stA@bastion.ttyv0.de> In-Reply-To: <86plujaklx.fsf@ltc.des.dev> References: <202404191540.43JFeDXd088443@gitrepo.freebsd.org> <86plujaklx.fsf@ltc.des.dev>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Hi des, On Sat, Apr 20, 2024 at 09:40:26PM +0200, Dag-Erling Smørgrav wrote: > Gordon Bergling <gbe@FreeBSD.org> writes: > > expand.1: Fix markup for the '-t' option > > > > When viewing the manpage the '-t' option is shown as follows > > > > -t -Sm tab1, tab2, ..., tabn Sm > > > > with the markup '\&Sm' included within '.It Fl t', which doesn't > > makes any sense. > > > > So just remove it. > > You can't just remove the Sm, you need to add Ns before and after each > comma to do what the Sm was intended to do. This is why we have a patch > review system, please use it. I usualy always create differentials for changes, but I try to avoid them for one-line changes. I have tested various combinations for the .Sm usage, but I didn't saw any change in the manual page formating when removing the macro, so that was the easiest thing to have the '-t' option not advertising a none existing '-Sm' option. --Gordon [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEYbWI0KY5X7yH/Fy4OQX2V8rP09wFAmYnw+gACgkQOQX2V8rP 09zWqAf5AdbDDc2359uTyAhHWEMTgBxdw0wMF7gL99vXHfPwdppd+YlIcdLUhQbw 7W+bxG3r9TzhlxF4ljJZxFfyQbYkMBptcCtnp6eb39sBZoFvRbFMC3LMA37VuvV3 Q/w3RNTC/M21U+g/TdniT9iWh1OjhLVmRuy//cKH1vWZ+zS+3XbMSKSwBcHhOLAB XoWOH0d5hAjTWnulHiFcTl2ehcrJa8b5KwfZE2z5Uld9Bz6ylY9q+YIuBZ3LGKu6 PQzRM2JLOpABXtP/oQysPT8R9MoQgRMghKcFjhnbFE4r7OlimIy7o9UEqkyJCMo7 Cnl1lKGiHzSUtJGHcuGorTngRqeWRA== =SRTp -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZifD6uvvAbmB4stA>