Date: Thu, 02 Sep 2010 16:33:31 +0300 From: Alexander Motin <mav@FreeBSD.org> To: bf1783@gmail.com Cc: freebsd-current@FreeBSD.org Subject: Re: One-shot-oriented event timers management Message-ID: <4C7FA7AB.4010905@FreeBSD.org> In-Reply-To: <AANLkTin3ZfGxW5aKBzdpokEEyvEjO6ifjUCKRBhS6vBN@mail.gmail.com> References: <AANLkTin3ZfGxW5aKBzdpokEEyvEjO6ifjUCKRBhS6vBN@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
b. f. wrote: > In: > http://people.freebsd.org/~mav/timers_oneshot7.patch > > you need to offset the declaration of 'cpu' in getnextevent() on line > 256 of src/sys/kern/kern_clocksource.c by #ifdef SMP, because it is > not used otherwise, and will break UP kernel builds with our default > warnings and -Werror. Thanks. > Incidentally, do you intend to commit the tm6292_idle.patch along with > the new timer code, after testing is satisfactory? Or is this not > appropriate for general use? If it isn't suitable for all users, > perhaps some of the periods of the events in that patch can be > abstracted and made tunable, so that we can make it possible to > conserve power, and also keep others happy? No, I am not going to commit it in present form. It is mostly made for technology preview. May be some parts of it could be committed as-is, but most of others are dirty hacks. I hope they should be safe enough, but they made with assumption of some tradeoffs and require proper rework or at least reevaluating. It would be nice if people aware with these areas (SCHED_ULE, TCP, CPU time resources, yarrow, console, GEOM) could review and reimplement them properly. -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C7FA7AB.4010905>