Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 23 Feb 2024 21:12:53 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 277269] [nanoBSD] setting NANO_PMAKE in defaults.sh renders setting NANO_NCPU in config useless
Message-ID:  <bug-277269-227@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277269

            Bug ID: 277269
           Summary: [nanoBSD] setting NANO_PMAKE in defaults.sh renders
                    setting NANO_NCPU in config useless
           Product: Base System
           Version: 14.0-RELEASE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: misc
          Assignee: bugs@FreeBSD.org
          Reporter: embhd@posteo.de

Created attachment 248702
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D248702&action=
=3Dedit
Patch

As of now, the default value of the variable NANO_PMAKE ("Parallel MAKE") as
set in the script `default.sh` contains the default value of NANO_NCPU ("Nu=
mber
of CPUs used").
Thus, if NANO_NCPU is set to a different value in the respective config fil=
e,
this won't change anything for the actual build, since the value of NANO_PM=
AKE
is not automatically updated to the configured number of cores - rendering =
the
variable more or less useless.

The proposed solution (c.f. the patch attached) is to eliminate the variable
NANO_PMAKE and use the "original" variables NANO_MAKE and NANO_NCPU directl=
y,
since it only affects two places in `defaults.sh=C2=B4.

In addition, the patch adds the missing available options to the output of
`nanobsd.sh -h`.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-277269-227>