Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 27 Oct 2014 23:44:04 -0700
From:      John-Mark Gurney <jmg@funkthat.com>
To:        Julian Elischer <julian@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r273762 - head/sys/modules/dtrace/dtraceall
Message-ID:  <20141028064404.GV82214@funkthat.com>
In-Reply-To: <201410280418.s9S4I9qh094390@svn.freebsd.org>
References:  <201410280418.s9S4I9qh094390@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Julian Elischer wrote this message on Tue, Oct 28, 2014 at 04:18 +0000:
> Author: julian
> Date: Tue Oct 28 04:18:09 2014
> New Revision: 273762
> URL: https://svnweb.freebsd.org/changeset/base/273762
> 
> Log:
>   Allow loading of dtraceall without nfscl if what you really wnat is nfsclient
>   
>   Obtained from:	Panzura tree
>   MFC after:	1 week
> 
> Modified:
>   head/sys/modules/dtrace/dtraceall/dtraceall.c
> 
> Modified: head/sys/modules/dtrace/dtraceall/dtraceall.c
> ==============================================================================
> --- head/sys/modules/dtrace/dtraceall/dtraceall.c	Tue Oct 28 03:42:09 2014	(r273761)
> +++ head/sys/modules/dtrace/dtraceall/dtraceall.c	Tue Oct 28 04:18:09 2014	(r273762)
> @@ -67,7 +67,9 @@ MODULE_DEPEND(dtraceall, cyclic, 1, 1, 1
>  MODULE_DEPEND(dtraceall, opensolaris, 1, 1, 1);
>  MODULE_DEPEND(dtraceall, dtrace, 1, 1, 1);
>  MODULE_DEPEND(dtraceall, dtmalloc, 1, 1, 1);
> +#if defined(NFSCLIENT)
>  MODULE_DEPEND(dtraceall, dtnfscl, 1, 1, 1);
> +#endif
>  #if defined(NFSCLIENT)
>  MODULE_DEPEND(dtraceall, dtnfsclient, 1, 1, 1);
>  #endif

Why not put the MODULE_DEPEND in the same #if defined block that follows?

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141028064404.GV82214>