Date: Thu, 30 Jan 2014 10:40:43 -0800 From: Adrian Chadd <adrian@freebsd.org> To: FreeBSD Net <freebsd-net@freebsd.org>, "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org> Subject: Re: (removing mbuf flowid setup in flowtable.c) Message-ID: <CAJ-Vmokh7AZdW3_G3CXDVzRfWm3EVz9kUeOWvHzr%2BG4SyNRyYg@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
On 30 January 2014 07:18, Adrian Chadd <adrian@freebsd.org> wrote:
> Hi,
>
> I'd like to disable the code in flowtable.c that assigns the mbuf flowid.
>
> I'd like to ensure that any mbuf flowid that's set is (eventually)
> going to be consistently toeplitz in the future (to match what NICs
> are doing on the RX side) and this may cause the flowid to be set to
> something completely different.
>
> I've only done some light production testing with this so far, to no
> visible ill effects.
>
> What do people think?
Someone pointed out privately that doing this would mean that UDP
flows without flow ids would suddenly not have flowids any longer and
thus wouldn't use multiple output queues.
So, I'll leave this alone for now until I can import the toeplitz hash
code into -HEAD and add an option to tag outbound udp frames with this
particular flowid hash.
Thanks,
-a
> Thanks,
>
>
> -a
>
>
> Index: sys/net/flowtable.c
> ===================================================================
> --- sys/net/flowtable.c (revision 261001)
> +++ sys/net/flowtable.c (working copy)
> @@ -1102,10 +1102,12 @@
> if (af == AF_INET6)
> fle = flowtable_lookup_mbuf6(ft, m);
> #endif
> +#if 0
> if (fle != NULL && m != NULL && (m->m_flags & M_FLOWID) == 0) {
> m->m_flags |= M_FLOWID;
> m->m_pkthdr.flowid = fle->f_fhash;
> }
> +#endif
> return (fle);
> }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmokh7AZdW3_G3CXDVzRfWm3EVz9kUeOWvHzr%2BG4SyNRyYg>