Date: Mon, 14 Aug 2006 16:02:16 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: Dmitry Pryanishnikov <dmitry@atlantis.dp.ua> Cc: Ruslan Ermilov <ru@freebsd.org>, src-committers@freebsd.org, Andrey Chernov <ache@freebsd.org>, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/gnu/usr.bin/groff/tmac Makefile Message-ID: <20060814130216.GM25753@deviant.kiev.zoral.com.ua> In-Reply-To: <20060814154640.R28464@atlantis.atlantis.dp.ua> References: <200608141221.k7ECLwHq069066@repoman.freebsd.org> <20060814124528.GB28932@nagual.pp.ru> <20060814154640.R28464@atlantis.atlantis.dp.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Mon, Aug 14, 2006 at 03:52:52PM +0300, Dmitry Pryanishnikov wrote: > > Hello! > > On Mon, 14 Aug 2006, Andrey Chernov wrote: > >> - Touch /usr/share/tmac/man.local if it already exists. > > > >It is definitely bad habbit touching the files to marking them not > >obsoleted. Many developers including me use 'INSTALL = install -C' which > >not touch files when not needed, so we have correct date of the actual > >last file change. With that your touching those files will falsely looks > >updated. Please back it out. > > Note that this commit does _not_ touch the file. As I've shown in my > previous letter, ':>>$file' will _not_ change file's modification time. > Maybe, we should avoid spelling ':>>' as a 'touch' in the commit log > to prevent such a confusion? BTW, knowing that ':>>$file' doesn't change > modification time, I'm really curiuos what this ".else / :>> / .endif" > really > does? Isn't this a plain NOOP?! It just opens file for write. Assuming /tmp/1 exists, watch yourself with truss sh -c ':>>/tmp/1'. On the other hand, touch uses utimes(2) to change file access and modification times. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFE4HRXC3+MBN1Mb4gRAvG8AKCXqMn4iayrJv5eTgUIISsEFWY2uwCg2uSM k76MEclP3U2lf5FTiTeQnlM= =DvMt -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060814130216.GM25753>