Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 17 May 2021 06:17:19 GMT
From:      Lutz Donnerhacke <donner@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 370c8a1f784c - stable/11 - service/ipfw: Silence warning on restart
Message-ID:  <202105170617.14H6HJHn051905@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/11 has been updated by donner:

URL: https://cgit.FreeBSD.org/src/commit/?id=370c8a1f784c62d0cf28aa1202a0575add1b3559

commit 370c8a1f784c62d0cf28aa1202a0575add1b3559
Author:     Lutz Donnerhacke <donner@FreeBSD.org>
AuthorDate: 2021-05-02 20:47:04 +0000
Commit:     Lutz Donnerhacke <donner@FreeBSD.org>
CommitDate: 2021-05-17 06:16:45 +0000

    service/ipfw: Silence warning on restart
    
    Once the ipfw0 interface has been created, ifconfig(8) create will
    throw a warning: "ifconfig: create: bad value" when trying to create
    it again.
    
    PR:             241013
    Submitted by:   Jose Luis Duran
    Approved by:    kp
    Differential Revision: https://reviews.freebsd.org/D30083
    
    (cherry picked from commit 5c4fe2ac81a5e05062266d684fb53b9faefd0d38)
---
 etc/rc.d/ipfw | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/etc/rc.d/ipfw b/etc/rc.d/ipfw
index ef85e3d88d13..b93d16026fe4 100755
--- a/etc/rc.d/ipfw
+++ b/etc/rc.d/ipfw
@@ -74,8 +74,14 @@ ipfw_start()
 		${SYSCTL} net.inet.ip.fw.verbose=1 >/dev/null
 	fi
 	if checkyesno firewall_logif; then
-		ifconfig ipfw0 create
-		echo 'Firewall logging pseudo-interface (ipfw0) created.'
+		if ! ifconfig ipfw0 >/dev/null 2>&1; then
+			ifconfig ipfw0 create
+			echo 'Firewall logging pseudo-interface (ipfw0)' \
+			    'created.'
+		else
+			echo 'Firewall logging pseudo-interface (ipfw0)' \
+			    'already created.'
+		fi
 	fi
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202105170617.14H6HJHn051905>