Date: Wed, 05 Sep 2001 18:34:08 -0400 From: Mike Tancsa <mike@sentex.net> To: "David E. Cross" <dec@freebsd.org> Cc: re@freebsd.org, stable@freebsd.org, freebsd-qa@freebsd.org Subject: Re: cvs commit: src/lib/libc/rpc svc_tcp.c svc_unix.c Message-ID: <5.1.0.14.0.20010905183253.039b5fa8@192.168.0.12> In-Reply-To: <200109052229.f85MTNJ32998@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
How would it be best to test this, and is it in the RC being rolled right now?
---Mike
At 03:29 PM 9/5/2001 -0700, David E. Cross wrote:
>dec 2001/09/05 15:29:23 PDT
>
> Modified files: (Branch: RELENG_4)
> lib/libc/rpc svc_tcp.c svc_unix.c
> Log:
> Submitted by: <crossd@cs.rpi.edu>
> Reviewed by: <re@freebsd.org>
> Approved by: <re@freebsd.org>
> Obtained from: <crossd@cs.rpi.edu>
> MFC after: N/A, -CURRENT no longer uses this code
> The patch in 1.28.2.1 was in error. It used FD_ZERO on the fds (fdset)
> structure, but this is a dunamically allocated array that is only as
> big as it needs to be. The result of calling FD_ZERO on it would be that
> it would either overwrite random data in the data-segment, happen to
> be just the right size and work correctly, or not zero out all of the
> data it was supposed to. The first case is far more likely (and damaging).
>
> This code has been in extensive testing here. And was approved by the
> release engineers for this last minute push.
>
> Revision Changes Path
> 1.18.2.3 +2 -2 src/lib/libc/rpc/Attic/svc_tcp.c
> 1.7.2.2 +2 -2 src/lib/libc/rpc/Attic/svc_unix.c
>
>
>To Unsubscribe: send mail to majordomo@FreeBSD.org
>with "unsubscribe cvs-all" in the body of the message
--------------------------------------------------------------------
Mike Tancsa, tel +1 519 651 3400
Network Administration, mike@sentex.net
Sentex Communications www.sentex.net
Cambridge, Ontario Canada www.sentex.net/mike
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-qa" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5.1.0.14.0.20010905183253.039b5fa8>