Date: Thu, 05 Nov 2009 12:18:53 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Giovanni Trematerra <giovanni.trematerra@gmail.com> Cc: Attilio Rao <attilio@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: [PATCH] AMD Opteron Rev. E hack Message-ID: <86k4y5fcde.fsf@ds4.des.no> In-Reply-To: <4e6cba830911050302k56bed35aj5ca9fa16379ab325@mail.gmail.com> (Giovanni Trematerra's message of "Thu, 5 Nov 2009 12:02:39 %2B0100") References: <4e6cba830911050302k56bed35aj5ca9fa16379ab325@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Giovanni Trematerra <giovanni.trematerra@gmail.com> writes: > I have a quick and dirty patch to address the problem as discussed on > commit r198868 in svn-src-head@ > I introduced BROKEN_OPTERON_E kernel option for i386/amd64 arch. > The patch isn't tested yet, I only successfully compiled on i386. > Can you let me know if the patch is on the right direction to resolve the= issue? > style(9) tips are welcomed. We should probably call it OPTERON_E_LFENCE_HACK or something, cf. NO_F00F_HACK (which has the opposite semantics - the f00f hack is enabled by default, though at this point we should probably reverse it and just print a warning if we detect a vulnerable CPU), and the wording of those printfs needs work, but it looks OK overall. BTW, you should use the text/x-patch MIME type for patches, instead of application/octet-stream. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86k4y5fcde.fsf>