Date: Mon, 8 Jan 2007 11:35:59 -0500 From: John Baldwin <jhb@freebsd.org> To: Pyun YongHyeon <yongari@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/msk if_msk.c Message-ID: <200701081135.59717.jhb@freebsd.org> In-Reply-To: <200701080019.l080Js9g077860@repoman.freebsd.org> References: <200701080019.l080Js9g077860@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday 07 January 2007 19:19, Pyun YongHyeon wrote:
> yongari 2007-01-08 00:19:53 UTC
>
> FreeBSD src repository
>
> Modified files:
> sys/dev/msk if_msk.c
> Log:
> Initialize legacy SYS_RES_IRQ resources before attempting to use MSI.
> This fixes legacy SYS_RES_IRQ resource allocation failure when MSI is
> disabled.
>
> Reported by: rrs
> Tested by: rrs
Gah, my bad. I would prefer to set it down before the 'if (msic == 2...)' so
all the logic for it is in one place, but anyways, you should remove the
now-duplicate setting here:
} else {
pci_release_msi(dev);
sc->msk_irq_spec = msk_irq_spec_legacy;
}
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200701081135.59717.jhb>