Date: Thu, 9 Apr 2020 18:38:00 +0000 (UTC) From: Konstantin Belousov <kib@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r359752 - head/sys/kern Message-ID: <202004091838.039Ic0IA092585@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: kib Date: Thu Apr 9 18:38:00 2020 New Revision: 359752 URL: https://svnweb.freebsd.org/changeset/base/359752 Log: Remove extra call to vfs_op_exit() from vfs_write_suspend() when VFS_SYNC() fails. The vfs_write_resume() handler already does vfs_op_exit() for us. Reported by: pho Reviewed by: mckusick Sponsored by: The FreeBSD Foundation Modified: head/sys/kern/vfs_vnops.c Modified: head/sys/kern/vfs_vnops.c ============================================================================== --- head/sys/kern/vfs_vnops.c Thu Apr 9 18:17:07 2020 (r359751) +++ head/sys/kern/vfs_vnops.c Thu Apr 9 18:38:00 2020 (r359752) @@ -1902,7 +1902,7 @@ vfs_write_suspend(struct mount *mp, int flags) MNT_IUNLOCK(mp); if ((error = VFS_SYNC(mp, MNT_SUSPEND)) != 0) { vfs_write_resume(mp, 0); - vfs_op_exit(mp); + /* vfs_write_resume does vfs_op_exit() for us */ } return (error); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202004091838.039Ic0IA092585>