Date: Mon, 11 Mar 2019 13:39:46 -0700 From: Ravi Pokala <rpokala@freebsd.org> To: Jung-uk Kim <jkim@FreeBSD.org>, Vladimir Kondratyev <wulf@FreeBSD.org>, <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org> Subject: Re: svn commit: r344982 - head/sys/x86/isa Message-ID: <1AF8F88B-4291-4EBA-8A56-530DABF5E833@panasas.com> In-Reply-To: <c7ad6dd0-5789-5e47-34c5-b33260f9845c@FreeBSD.org> References: <201903102019.x2AKJiJY029807@repo.freebsd.org> <00F61A40-C128-4F75-A45F-A6CECBB791C2@panasas.com> <c7ad6dd0-5789-5e47-34c5-b33260f9845c@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
That did the trick, and I see that Vladimir has already submitted it. Thank you both! -Ravi (rpokala@) -----Original Message----- From: <owner-src-committers@freebsd.org> on behalf of Jung-uk Kim <jkim@FreeBSD.org> Date: 2019-03-11, Monday at 11:17 To: Ravi Pokala <rpokala@freebsd.org>, Vladimir Kondratyev <wulf@FreeBSD.org>, <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org> Subject: Re: svn commit: r344982 - head/sys/x86/isa On 19. 3. 11., Ravi Pokala wrote: > -----Original Message----- > From: <owner-src-committers@freebsd.org> on behalf of Vladimir Kondratyev <wulf@FreeBSD.org> > Date: 2019-03-10, Sunday at 13:19 > To: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org> > Subject: svn commit: r344982 - head/sys/x86/isa > >> Author: wulf >> Date: Sun Mar 10 20:19:43 2019 >> New Revision: 344982 >> URL: https://svnweb.freebsd.org/changeset/base/344982 >> >> Log: >> atrtc(4): install ACPI RTC/CMOS operation region handler > > Hi Vladimir, > > This appears to have broken all the various LINT kernels for amd64 and i386: > > ================================================================ > /usr/home/rpokala/freebsd/clean/base/head/sys/x86/isa/atrtc.c:321:2: error: use of undeclared identifier '_AcpiModuleName' > ACPI_FUNCTION_TRACE((char *)(uintptr_t)__func__); > ^ > /usr/home/rpokala/freebsd/clean/base/head/sys/contrib/dev/acpica/include/acoutput.h:480:18: note: expanded from macro 'ACPI_FUNCTION_TRACE' > AcpiUtTrace (ACPI_DEBUG_PARAMETERS) > ^ > /usr/home/rpokala/freebsd/clean/base/head/sys/contrib/dev/acpica/include/acoutput.h:402:39: note: expanded from macro 'ACPI_DEBUG_PARAMETERS' > __LINE__, ACPI_GET_FUNCTION_NAME, _AcpiModuleName, _COMPONENT > ^ > /usr/home/rpokala/freebsd/clean/base/head/sys/x86/isa/atrtc.c:321:2: error: use of undeclared identifier '_COMPONENT' > /usr/home/rpokala/freebsd/clean/base/head/sys/contrib/dev/acpica/include/acoutput.h:480:18: note: expanded from macro 'ACPI_FUNCTION_TRACE' > AcpiUtTrace (ACPI_DEBUG_PARAMETERS) > ^ > /usr/home/rpokala/freebsd/clean/base/head/sys/contrib/dev/acpica/include/acoutput.h:402:56: note: expanded from macro 'ACPI_DEBUG_PARAMETERS' > __LINE__, ACPI_GET_FUNCTION_NAME, _AcpiModuleName, _COMPONENT > ^ > ================================================================ > > That same pattern of errors is noted for lines 321, 362, and 386. > > Please take a look at your earliest convenience. Please try the attached patch. Jung-uk Kim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1AF8F88B-4291-4EBA-8A56-530DABF5E833>