Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 14 Jul 2020 11:00:26 -0400
From:      Jung-uk Kim <jkim@FreeBSD.org>
To:        Adrian Chadd <adrian@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Cc:        Kyle Evans <kevans@FreeBSD.org>
Subject:   Re: svn commit: r363171 - head/contrib/flex/src
Message-ID:  <953fd975-215b-2d53-23e6-58faa6af9c96@FreeBSD.org>
In-Reply-To: <202007140500.06E508mV016928@repo.freebsd.org>
References:  <202007140500.06E508mV016928@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 20. 7. 14., Adrian Chadd wrote:
> Author: adrian
> Date: Tue Jul 14 05:00:08 2020
> New Revision: 363171
> URL: https://svnweb.freebsd.org/changeset/base/363171
> 
> Log:
>   [flex] Fix compilation issue under mips-gcc-6.4
>   
>   This was triggering a pointer-losing-constness error.
> 
> Modified:
>   head/contrib/flex/src/main.c
> 
> Modified: head/contrib/flex/src/main.c
> ==============================================================================
> --- head/contrib/flex/src/main.c	Tue Jul 14 01:54:24 2020	(r363170)
> +++ head/contrib/flex/src/main.c	Tue Jul 14 05:00:08 2020	(r363171)
> @@ -342,7 +342,7 @@ void check_options (void)
>      /* Setup the filter chain. */
>      output_chain = filter_create_int(NULL, filter_tee_header, headerfilename);
>      if ( !(m4 = getenv("M4"))) {
> -	    char *slash;
> +		const char *slash;
>  		m4 = M4;
>  		if ((slash = strrchr(M4, '/')) != NULL) {
>  			m4 = slash+1;
> 

It was discussed in this ML.

https://lists.freebsd.org/pipermail/svn-src-head/2020-June/137432.html

kevans even filed an upstream pull request.

https://github.com/westes/flex/pull/449

Why did you commit it without asking us?

Jung-uk Kim



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?953fd975-215b-2d53-23e6-58faa6af9c96>