Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 25 Feb 2026 17:20:20 +0000
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 0e5caac7d543 - main - ipsec_offload: add comment stating why ipsec_accel_sa_newkey_cb() returns 0
Message-ID:  <699f2f54.3891e.7d80e848@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by kib:

URL: https://cgit.FreeBSD.org/src/commit/?id=0e5caac7d543687d540fa83a7125726c7c9e6e58

commit 0e5caac7d543687d540fa83a7125726c7c9e6e58
Author:     Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2026-02-04 02:34:59 +0000
Commit:     Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2026-02-25 17:19:36 +0000

    ipsec_offload: add comment stating why ipsec_accel_sa_newkey_cb() returns 0
    
    Reviewed by:    slavash
    Tested by:      Wafa Hamzah <wafah@nvidia.com>
    Sponsored by:   NVidia networking
    MFC after:      1 week
---
 sys/netipsec/ipsec_offload.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sys/netipsec/ipsec_offload.c b/sys/netipsec/ipsec_offload.c
index 23d36c395c43..e3a9d3247491 100644
--- a/sys/netipsec/ipsec_offload.c
+++ b/sys/netipsec/ipsec_offload.c
@@ -343,6 +343,13 @@ ipsec_accel_sa_newkey_cb(if_t ifp, void *arg)
 		}
 	}
 out:
+	/*
+	 * Return 0, ignoring any errors from the SA installation.
+	 * This function is a callback for if_foreach_sleep(), which
+	 * stops iteration if one of the callbacks returns non-zero.
+	 * We need to offer the SA to all interfaces that could
+	 * offload it.
+	 */
 	return (0);
 }
 


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?699f2f54.3891e.7d80e848>