Date: Sat, 4 Nov 2017 13:13:01 -0700 From: Mark Millard <markmi@dsl-only.net> To: Ed Maste <emaste@freebsd.org> Cc: Andriy Gapon <avg@freebsd.org>, FreeBSD Toolchain <freebsd-toolchain@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: svn commit: r325320 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs [breaks lld on zfs: lld uses fallocate] Message-ID: <9D762BA9-D957-4413-98E1-E4410BA20112@dsl-only.net> In-Reply-To: <CAPyFy2DYXvW%2BNo4kvaqGHFSPU7iH71suGCpvNgb3DPGScgUa_g@mail.gmail.com> References: <6140C4E2-168F-4E5D-B3C2-717ECB67C980@dsl-only.net> <134eea8e-1a2e-d77c-f7fa-01e14db7f47b@FreeBSD.org> <CAPyFy2DYXvW%2BNo4kvaqGHFSPU7iH71suGCpvNgb3DPGScgUa_g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2017-Nov-4, at 4:58 AM, Ed Maste <emaste at freebsd.org> wrote:
> On 4 November 2017 at 07:41, Andriy Gapon <avg at freebsd.org> wrote:
>> On 04/11/2017 12:32, Mark Millard wrote:
>>> if (int Err = ::posix_fallocate(FD, 0, Size)) {
>>> if (Err != EOPNOTSUPP)
>>> return std::error_code(Err, std::generic_category());
>>> }
>>
>> The commit message that you didn't include into your reply contains some useful
>> information that authors / maintainers of this code should probably take into
>> account:
>>
>>> Please note that EINVAL is used to report that the underlying file system
>>> does not support the operation (POSIX.1-2008).
>>
>> Here is a link for that:
>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/posix_fallocate.html
>
> I have no idea how they decided EINVAL was a reasonable errno for this case.
I think they viewed it as a bad fd argument: a reference
into a wrong file system, much like a wrong len (<0) or
offset (<0).
That there is no other means of run-time classifying the
file system(s)(?) was not viewed as sufficient reason
to give it a different classification.
But it is just a guess.
===
Mark Millard
markmi at dsl-only.net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9D762BA9-D957-4413-98E1-E4410BA20112>