Date: Mon, 21 Dec 2009 12:34:25 -0800 From: Doug Barton <dougb@FreeBSD.org> To: Hajimu UMEMOTO <ume@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, freebsd-rc@FreeBSD.org Subject: Re: svn commit: r200743 - in head/usr.sbin: . service Message-ID: <4B2FDBD1.7030808@FreeBSD.org> In-Reply-To: <ygeaaxcfqdw.wl%ume@mahoroba.org> References: <200912200134.nBK1YCAA048942@svn.freebsd.org> <yged42ackpc.wl%ume@mahoroba.org> <4B2DBB51.9060002@FreeBSD.org> <ygebphuceaw.wl%ume@mahoroba.org> <4B2DD2A1.8060907@FreeBSD.org> <ygeaaxec7oz.wl%ume@mahoroba.org> <4B2E84CF.2060902@FreeBSD.org> <ygeaaxcfqdw.wl%ume@mahoroba.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hajimu UMEMOTO wrote: >>>>>> On Sun, 20 Dec 2009 12:10:55 -0800 >>>>>> Doug Barton <dougb@FreeBSD.org> said: > > dougb> I agree to making the change you suggested, but I would like to > dougb> quibble over the format. Isn't the attached patch equivalent, and > dougb> simpler? What is the value of setting HOME and PATH in the environment > dougb> if we're just going to use 'env -i HOME PATH' anyway? > > Yup, your attached patch is equivalent. However, I prefer the > previous one. In anyway, I don't have a strong opinion around here. Thanks for confirming. My preference generally is for things to be simple and clear which makes them less confusing down the road. I've committed the patch I posted. Thanks again to everyone who offered their feedback. I'll wait a little longer before MFC'ing this, but I do want to get it in ASAP. Doug -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B2FDBD1.7030808>