Date: Sun, 7 Nov 2010 17:54:20 -0800 From: Juli Mallett <jmallett@FreeBSD.org> To: "David E. O'Brien" <obrien@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r214961 - head/usr.bin/yacc Message-ID: <AANLkTi=zKy%2B%2Bq2DLreKR6Gt4ykTKfjymO7f47pG-jH0A@mail.gmail.com> In-Reply-To: <201011072322.oA7NMhb0092364@svn.freebsd.org> References: <201011072322.oA7NMhb0092364@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
David, On Sun, Nov 7, 2010 at 15:22, David E. O'Brien <obrien@freebsd.org> wrote: > Author: obrien > Date: Sun Nov =A07 23:22:42 2010 > New Revision: 214961 > URL: http://svn.freebsd.org/changeset/base/214961 > > Log: > =A0Directly use memory allocation functions and remove needless casts in > =A0their usage. =A0Also use associated modern types instead of k&r ones. You do know that changing skeleton.c affects the generated files, right? I'm wondering if whatever sed script you're judiciously-applying knows that. C++ does not do implicit conversions from "void *" so you need the casts on the mallocs there. With a C++ compiler: y.tab.c:116: error: invalid conversion from 'void*' to 'short int*' y.tab.c:122: error: invalid conversion from 'void*' to 'YYSTYPE*' Please back out the changes to the skeleton.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTi=zKy%2B%2Bq2DLreKR6Gt4ykTKfjymO7f47pG-jH0A>